Skip to content

docs: document setup files #3996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 27, 2025
Merged

docs: document setup files #3996

merged 8 commits into from
Feb 27, 2025

Conversation

davidcavazos
Copy link
Contributor

Description

Document setup files options available for Node.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 27, 2025
@davidcavazos davidcavazos marked this pull request as ready for review February 27, 2025 20:55
@davidcavazos davidcavazos requested review from a team as code owners February 27, 2025 20:55
briandorsey
briandorsey approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@briandorsey briandorsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Medium term, I think we should consider how DRY we want to be about repeating text between repos vs. having everything in one place for folks. But I think that conversation should happen later and not block this.

@davidcavazos davidcavazos merged commit fe903de into main Feb 27, 2025
12 checks passed
@davidcavazos davidcavazos deleted the docs-setup-files branch February 27, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandorsey briandorsey briandorsey approved these changes

Assignees
No one assigned
Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidcavazos @briandorsey